zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r739750417
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperTransporter.java
##########
@@ -31,10 +31,12 @@
ZookeeperClient connect(URL url);
- void destroy();
+ void close(ZookeeperClient zookeeperClient, String application);
- static ZookeeperTransporter getExtension(ApplicationModel
applicationModel) {
- ExtensionLoader<ZookeeperTransporter> extensionLoader =
applicationModel.getExtensionLoader(ZookeeperTransporter.class);
+ void close(String application);
+
+ static ZookeeperTransporter getExtension() {
+ ExtensionLoader<ZookeeperTransporter> extensionLoader =
FrameworkModel.defaultModel().getExtensionLoader(ZookeeperTransporter.class);
Review comment:
FrameworkModel.defaultModel() is still found in 3.0 branch everywhere,
should we modified them all together?
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperTransporter.java
##########
@@ -31,10 +31,12 @@
ZookeeperClient connect(URL url);
- void destroy();
+ void close(ZookeeperClient zookeeperClient, String application);
- static ZookeeperTransporter getExtension(ApplicationModel
applicationModel) {
- ExtensionLoader<ZookeeperTransporter> extensionLoader =
applicationModel.getExtensionLoader(ZookeeperTransporter.class);
+ void close(String application);
+
+ static ZookeeperTransporter getExtension() {
+ ExtensionLoader<ZookeeperTransporter> extensionLoader =
FrameworkModel.defaultModel().getExtensionLoader(ZookeeperTransporter.class);
Review comment:
FrameworkModel.defaultModel() is still found in 3.0 branch everywhere,
should we modify them all together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
