pinxiong commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743359356
##########
File path:
dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of
zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> Pls add JVM arg to disable embedded zk server, allow users to use
external zk server.
It's done.
##########
File path:
dubbo-test/dubbo-test-check/src/main/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener
##########
@@ -1 +1,5 @@
+# DubboRegistryCenterStarted should be the first one because of the startup of
zookeeper
+org.apache.dubbo.test.check.RegistryCenterStarted
Review comment:
> When enable thread checking by `-DcheckThreads=true`,
`DubboTestChecker` will dump threads after finished each test class. The
embedded zk server will also create some threads, such as creating a new netty
thread when establishing a connection, which will interfere with the thread
check of dubbo test. Is it possible to start zk server in a separate process?
Now, it can use a dependent process to start zookeeper server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
