kylixs commented on a change in pull request #9138:
URL: https://github.com/apache/dubbo/pull/9138#discussion_r743410711
##########
File path:
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/multiple/exportmetadata/MultipleRegistryCenterExportMetadataIntegrationTest.java
##########
@@ -99,13 +91,9 @@ public void setUp() throws Exception {
DubboBootstrap.getInstance()
.application(new ApplicationConfig(PROVIDER_APPLICATION_NAME))
.protocol(new ProtocolConfig(PROTOCOL_NAME))
- .service(serviceConfig);
- for (RegistryCenter.Instance instance :
registryCenter.getRegistryCenterInstance()) {
- DubboBootstrap.getInstance().registry(new
RegistryConfig(String.format("%s://%s:%s",
- instance.getType(),
- instance.getHostname(),
- instance.getPort())));
- }
+ .service(serviceConfig)
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2181"))
+ .registry(new RegistryConfig("zookeeper://127.0.0.1:2182"));
Review comment:
Is it possible to define global zk server port/address variables and
then quote them in test? It is better not to use the port 2181 by default to
avoid port conflicts on the zk server. Just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
