BurningCN commented on a change in pull request #9372:
URL: https://github.com/apache/dubbo/pull/9372#discussion_r765689335
##########
File path:
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
##########
@@ -40,27 +40,22 @@
public class ZookeeperDynamicConfiguration extends
TreePathDynamicConfiguration {
private Executor executor;
- // The final root path would be: /configRootPath/"config"
- private String rootPath;
private ZookeeperClient zkClient;
private CacheListener cacheListener;
- private URL url;
private static final int DEFAULT_ZK_EXECUTOR_THREADS_NUM = 1;
private static final int DEFAULT_QUEUE = 10000;
private static final Long THREAD_KEEP_ALIVE_TIME = 0L;
ZookeeperDynamicConfiguration(URL url, ZookeeperTransporter
zookeeperTransporter) {
super(url);
- this.url = url;
- rootPath = getRootPath(url);
Review comment:
The parent class already has a rootPath, so we don’t need to get it again
The url is not used so it is deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
