BurningCN commented on a change in pull request #9372:
URL: https://github.com/apache/dubbo/pull/9372#discussion_r765690027
##########
File path:
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java
##########
@@ -79,13 +79,10 @@
/* apps - listener */
private final Map<String, ServiceInstancesChangedListener>
serviceListeners = new ConcurrentHashMap<>();
- private RegistryManager registryManager;
-
public ServiceDiscoveryRegistry(URL registryURL) {
super(registryURL);
this.serviceDiscovery = createServiceDiscovery(registryURL);
this.writableMetadataService =
WritableMetadataService.getDefaultExtension(registryURL.getScopeModel());
- this.registryManager =
registryURL.getOrDefaultApplicationModel().getBeanFactory().getBean(RegistryManager.class);
Review comment:
The parent class already has this attribute, so we don’t need to get it
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
