[GitHub] [dubbo] kylixs commented on a change in pull request #9381: Adjust the logic of Deployer to handle concurrent initialization

[GitBox]

kylixs commented on a change in pull request #9381:
URL: https://github.com/apache/dubbo/pull/9381#discussion_r773571818



##########
File path: 
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
##########
@@ -92,14 +92,8 @@ public DefaultModuleDeployer(ModuleModel moduleModel) {
 
     @Override
     public void initialize() throws IllegalStateException {
-        if (initialized.get()) {
-            return;
-        }
         // Ensure that the initialization is completed when concurrent calls
-        synchronized (this) {
-            if (initialized.get()) {
-                return;
-            }
+        if (initialized.compareAndSet(false, true)) {
             loadConfigs();

Review comment:
       see `DefaultApplicationDeployer.initialize()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org