[GitHub] [dubbo] BurningCN commented on a change in pull request #9381: Adjust the logic of Deployer to handle concurrent initialization

[GitBox]

BurningCN commented on a change in pull request #9381:
URL: https://github.com/apache/dubbo/pull/9381#discussion_r773671729



##########
File path: 
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
##########
@@ -691,7 +694,7 @@ private DynamicConfiguration 
prepareEnvironment(ConfigCenterConfig configCenter)
             } catch (Exception e) {
                 if (!configCenter.isCheck()) {
                     logger.warn("The configuration center failed to 
initialize", e);
-                    configCenter.checkOrUpdateInitialized(false);
+                    configCenter.setInitialized(false);

Review comment:
       As shown below, sequence number 1 will change `initialized` from false 
to true, but sequence number 2 cannot set `initialized` to false, so adjust to 
`configCenter.setInitialized(false);`
   
![image](https://user-images.githubusercontent.com/43363120/147056118-9ccefa0c-8d45-41dd-bd42-7a027a94ce12.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org