BurningCN commented on code in PR #10389:
URL: https://github.com/apache/dubbo/pull/10389#discussion_r933811937
##########
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractConfigTest.java:
##########
@@ -188,6 +191,8 @@ public void testAppendAttributes1() throws Exception {
Assertions.assertEquals(String.valueOf(config.getNumber()),
attributes.get("number"));
Assertions.assertEquals(String.valueOf(config.getAge()),
attributes.get("age"));
Assertions.assertEquals(StringUtils.encodeParameters(config.getParameters()),
attributes.get("parameters"));
+ Assertions.assertTrue(parameters.containsKey("detail.address"));//
detailAddress -> detail.address
+ Assertions.assertTrue(attributes.containsKey("detail-address"));//
detailAddress -> detail-address
Review Comment:
`appendParameters`和`appendAttributes`在遇到驼峰属性名比如`detailAddress`，会生成不同结果，分别是`detail.address`和`detail-address。`
##########
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractConfigTest.java:
##########
@@ -188,6 +191,8 @@ public void testAppendAttributes1() throws Exception {
Assertions.assertEquals(String.valueOf(config.getNumber()),
attributes.get("number"));
Assertions.assertEquals(String.valueOf(config.getAge()),
attributes.get("age"));
Assertions.assertEquals(StringUtils.encodeParameters(config.getParameters()),
attributes.get("parameters"));
+ Assertions.assertTrue(parameters.containsKey("detail.address"));//
detailAddress -> detail.address
+ Assertions.assertTrue(attributes.containsKey("detail-address"));//
detailAddress -> detail-address
Review Comment:
添加case，`appendParameters`和`appendAttributes`在遇到驼峰属性名比如`detailAddress`，会生成不同结果，分别是`detail.address`和`detail-address。`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
