BurningCN commented on code in PR #10389:
URL: https://github.com/apache/dubbo/pull/10389#discussion_r933811369
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java:
##########
@@ -776,7 +795,7 @@ private void assignProperties(Object obj, Environment
environment, Map<String, S
oldMap.forEach(newMap::putIfAbsent);
}
- invokeSetParameters(newMap, obj);
+ invokeSetParameters(obj.getClass(), obj, newMap);
Review Comment:
AbstractConfig有两个`invokeSetParameters`方法，这里修改成功直接调用`三参数的invokeSetParameters`方法。
`两参数的invokeSetParameters`内部就是获取原config的parameters 然后
newMap.putAll(parameters)，但是这部分逻辑在798行上面已经处理了，不需要再在`两参数的invokeSetParameters`重复处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
