BurningCN commented on code in PR #10389:
URL: https://github.com/apache/dubbo/pull/10389#discussion_r934112989
##########
dubbo-common/src/main/java/org/apache/dubbo/config/context/ConfigConfigurationAdapter.java:
##########
@@ -31,14 +30,10 @@ public class ConfigConfigurationAdapter implements
Configuration {
private Map<String, String> metaData;
public ConfigConfigurationAdapter(AbstractConfig config, String prefix) {
- Map<String, String> configMetadata = config.getMetaData();
if (StringUtils.hasText(prefix)) {
- metaData = new HashMap<>(configMetadata.size(), 1.0f);
- for (Map.Entry<String, String> entry : configMetadata.entrySet()) {
- metaData.put(prefix + "." + entry.getKey(), entry.getValue());
- }
+ metaData = config.getMetaData(prefix);
Review Comment:
如果有`prefix`，直接调用`AbstractConfig`新增的`getMetaData(prefix)`方法，不需要像原有逻辑那样：
`config.getMetaData() `+ 遍历`configMetadata`给每个`entry`的`key`拼接`prefix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
