BurningCN commented on code in PR #10389:
URL: https://github.com/apache/dubbo/pull/10389#discussion_r933810571
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java:
##########
@@ -656,14 +671,15 @@ public void refresh() {
// Search props starts with PREFIX in order
String preferredPrefix = null;
- for (String prefix : getPrefixes()) {
+ List<String> prefixes = getPrefixes();
+ for (String prefix : prefixes) {
if (ConfigurationUtils.hasSubProperties(configurationMaps,
prefix)) {
preferredPrefix = prefix;
break;
}
}
if (preferredPrefix == null) {
- preferredPrefix = getPrefixes().get(0);
Review Comment:
这里和659行重复调用getPrefixes()，合成一次调用放在674行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
