TrueAbc commented on code in PR #10395:
URL: https://github.com/apache/dubbo/pull/10395#discussion_r935107278
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##########
@@ -170,6 +171,6 @@ public void configClientPipeline(URL url, ChannelPipeline
pipeline, SslContext s
.build();
final Http2MultiplexHandler handler = new Http2MultiplexHandler(
new TripleClientHandler(frameworkModel));
- pipeline.addLast(codec, handler, new TripleTailHandler());
+ pipeline.addLast(new TelnetHeaderConsumer(), codec, handler, new
TripleTailHandler());
Review Comment:
For a telnet connection, pu server need to send prompt message to the
client(pu server don't know client protocol type, may triple, may telnet of
qos). If client is a triple client, this decoder is responsible for consume
prompt message which is useless for triple client(or will cause wrong tcp
stream unpack).
- I am investigating telnet protocol and telnet command so that client could
send some message to server once connected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
