TrueAbc commented on code in PR #10395:
URL: https://github.com/apache/dubbo/pull/10395#discussion_r940287582
##########
dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java:
##########
@@ -102,6 +104,14 @@ private void startQosServer(URL url) {
"dubbo.properties or XML/spring-boot configuration.");
return;
}
+ // frameModel of mock url is null
+ FrameworkModel frameworkModel1= url.getOrDefaultFrameworkModel();
+ if (frameworkModel1 != null) {
+ WireProtocol protocol1 =
frameworkModel1.getExtensionLoader(WireProtocol.class).getExtension("qos");
+ if(protocol1 != null) {
+ ((QosWireProtocol) protocol1).SetQosEnable(true);
Review Comment:
if qosEnable is not true, this logic won't work. and default flag for
qoswireProtocol to enable qos detector in pu server is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
