AlbumenJ commented on code in PR #10533:
URL: https://github.com/apache/dubbo/pull/10533#discussion_r961328604
##########
dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvokerAvailableTest.java:
##########
@@ -151,6 +151,26 @@ public void test_Lazy_ChannelReadOnly() throws Exception {
Assertions.assertFalse(invoker.isAvailable());
}
+ /**
+ * The test prefer serialization
+ *
+ * @throws Exception 异常
Review Comment:
comment in eng
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java:
##########
@@ -110,13 +110,7 @@
import static org.apache.dubbo.registry.Constants.REGISTER_KEY;
import static org.apache.dubbo.registry.Constants.REGISTRY_RETRY_PERIOD_KEY;
import static org.apache.dubbo.registry.Constants.SIMPLIFIED_KEY;
-import static org.apache.dubbo.remoting.Constants.BIND_IP_KEY;
-import static org.apache.dubbo.remoting.Constants.BIND_PORT_KEY;
-import static org.apache.dubbo.remoting.Constants.CHECK_KEY;
-import static org.apache.dubbo.remoting.Constants.CODEC_KEY;
-import static org.apache.dubbo.remoting.Constants.CONNECTIONS_KEY;
-import static org.apache.dubbo.remoting.Constants.EXCHANGER_KEY;
-import static org.apache.dubbo.remoting.Constants.SERIALIZATION_KEY;
+import static org.apache.dubbo.remoting.Constants.*;
Review Comment:
do not use comma import
##########
dubbo-common/src/main/java/org/apache/dubbo/common/constants/ProviderConstants.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.dubbo.common.constants;
+
+/**
+ * Provider Constants
+ *
+ * @author XS <[email protected]>
+ * @date: 2022/9/1 16:59:53
+ * @since 1.0
Review Comment:
remove these tags pls
##########
dubbo-common/src/main/java/org/apache/dubbo/common/constants/ProviderConstants.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.dubbo.common.constants;
Review Comment:
Please add ASF license header to all files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
