AlbumenJ commented on code in PR #10533:
URL: https://github.com/apache/dubbo/pull/10533#discussion_r962107968
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/AbstractServiceBuilder.java:
##########
@@ -211,11 +216,22 @@ public B warmup(Integer warmup) {
return getThis();
}
- public B serialization(String serialization) {
+ public B serialization(String serialization) {
this.serialization = serialization;
return getThis();
}
+ /**
+ * The prefer serialization type
+ *
+ * @param preferSerialization 喜欢序列化
Review Comment:
comment in eng
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/utils/UrlUtils.java:
##########
@@ -18,7 +18,15 @@
package org.apache.dubbo.remoting.utils;
import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.serialize.support.DefaultSerializationSelector;
+import org.apache.dubbo.common.utils.StringUtils;
import org.apache.dubbo.remoting.Constants;
+import org.apache.dubbo.remoting.transport.CodecSupport;
+
+import java.util.*;
Review Comment:
do not use comma import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
