yang20150702 commented on code in PR #103:
URL: https://github.com/apache/dubbo-rust/pull/103#discussion_r1083623869
##########
dubbo/src/triple/client/triple.rs:
##########
@@ -83,6 +92,14 @@ impl<T> TripleClient<T> {
self.builder.unwrap(),
)
}
+
Review Comment:
Dubbo的一个特性是配置优先。我建议可以将服务发现相关的配置放到clientBuilder中，通过配置来启动服务发现；这样可以简化dubbo-build侧client生成的代码
另外，自定义配置directory应该是高级能力。
##########
dubbo/src/invocation.rs:
##########
@@ -189,3 +189,35 @@ impl Metadata {
header
}
}
+
Review Comment:
implementation of RpcInvocation is too complicated. Now we can use a struct
as metadata. In future, we can rebuild this struct by new requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
