AlbumenJ commented on code in PR #103:
URL: https://github.com/apache/dubbo-rust/pull/103#discussion_r1101347212
##########
dubbo-build/src/client.rs:
##########
@@ -66,45 +66,39 @@ pub fn generate<T: Service>(
#service_doc
#(#struct_attributes)*
#[derive(Debug, Clone, Default)]
- pub struct #service_ident<T> {
- inner: TripleClient<T>,
+ pub struct #service_ident {
+ inner: TripleClient,
}
- impl #service_ident<ClientBoxService> {
+ impl #service_ident {
pub fn connect(host: String) -> Self {
let cli = TripleClient::connect(host);
#service_ident {
inner: cli,
}
}
- pub fn build(builder: ClientBuilder) -> Self {
- Self {
- inner: TripleClient::with_builder(builder),
- }
- }
- }
+ // pub fn build(builder: ClientBuilder) -> Self {
+ // Self {
+ // inner: TripleClient::new(builder),
+ // }
+ // }
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
