AlbumenJ commented on code in PR #11498:
URL: https://github.com/apache/dubbo/pull/11498#discussion_r1099468461
##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java:
##########
@@ -638,6 +639,12 @@ private URL buildURL(URL consumerURL, Instance instance) {
return new DubboServiceAddressURL(url.getUrlAddress(),
url.getUrlParam(), consumerURL, null);
}
+
+ private void setWeight(Map<String, String> metadata, double nacosWeight) {
+ long weight =
Math.round(org.apache.dubbo.rpc.cluster.Constants.DEFAULT_WEIGHT * nacosWeight);
Review Comment:
`Math.round(org.apache.dubbo.rpc.cluster.Constants.DEFAULT_WEIGHT *
nacosWeight)` will override the weight from Dubbo provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
