[GitHub] [dubbo] November22 commented on a diff in pull request #11498: Enhanced support for Nacos weight configuration

[via GitHub]

November22 commented on code in PR #11498:
URL: https://github.com/apache/dubbo/pull/11498#discussion_r1109174992


##########
dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java:
##########
@@ -638,6 +639,12 @@ private URL buildURL(URL consumerURL, Instance instance) {
         return new DubboServiceAddressURL(url.getUrlAddress(), 
url.getUrlParam(), consumerURL, null);
     }
 
+
+    private void setWeight(Map<String, String> metadata, double nacosWeight) {
+        long weight = 
Math.round(org.apache.dubbo.rpc.cluster.Constants.DEFAULT_WEIGHT * nacosWeight);

Review Comment:
   Are you referring to 
org.apache.dubbo.registry.nacos.NacosRegistry#createInstance? I see that when 
creating an instance here, the weight of the dubbo configuration is not set. 
Here, the weight of the dubbo configuration can be registered on Nacos, and the 
weight issued by Nacos shall prevail when obtaining it. In this way, there will 
be no scenarios covered by Nacos.
   
![image](https://user-images.githubusercontent.com/26109828/219523718-26663581-00a7-4ac7-bfe3-8b86341404ee.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org