wxbty commented on code in PR #11088:
URL: https://github.com/apache/dubbo/pull/11088#discussion_r1109937478
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/DecodeHandler.java:
##########
@@ -38,19 +39,33 @@ public DecodeHandler(ChannelHandler handler) {
@Override
public void received(Channel channel, Object message) throws
RemotingException {
+ doRecveived(message);
+
+
+ try {
+ handler.received(channel, message);
+ } catch (RetryHandleException e) {
+ if (message instanceof Request) {
+ Request request = (Request) message;
+ retry(request.getData());
+ } else {
+ // Retry only once, and only Request will throw an
RetryHandleException
+ throw new RemotingException(channel, "Unknown error
encountered when retry handle: " + e.getMessage());
+ }
+ handler.received(channel, message);
Review Comment:
I don't quite understand what you mean, is there any hidden danger here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
