wxbty commented on code in PR #11088:
URL: https://github.com/apache/dubbo/pull/11088#discussion_r1112059854
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/Request.java:
##########
@@ -41,6 +41,9 @@ public class Request {
private Object mData;
+ private Throwable mError;
+
+
Review Comment:
When an SNF exception occurs, we need to store the decoded content in the
request object, and store the error tag at the same time. At this time, only
one field may be troublesome. If can solve this problem, we can reuse.
```java
try {
handler.received(channel, message);
} catch (RetryHandleException e) {
if (message instanceof Request) {
Request request = (Request) message;
retry(request.getData()); //Here requires partially decoded content
} else {
throw new RemotingException(channel, "Unknown error encountered when
retry handle: " + e.getMessage());
}
handler.received(channel, message);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
