icodening commented on code in PR #11859:
URL: https://github.com/apache/dubbo/pull/11859#discussion_r1150001416
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/UnaryServerCallListener.java:
##########
@@ -55,12 +56,32 @@ public void onCancel(TriRpcStatus status) {
@Override
protected void doOnResponseHasException(Throwable t) {
if (needWrapper) {
- onReturn(t);
+ if (t instanceof Exception) {
+ onReturnException(t);
+ } else {
+ onReturn(t);
+ }
} else {
super.doOnResponseHasException(t);
}
}
+ private void onReturnException(Object value) {
Review Comment:
`Exception value` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
