EarthChen commented on code in PR #11859:
URL: https://github.com/apache/dubbo/pull/11859#discussion_r1158339835
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/ClientCall.java:
##########
@@ -53,7 +53,7 @@ interface Listener {
* @param status response status
* @param trailers response trailers
*/
- void onClose(TriRpcStatus status, Map<String, Object> trailers);
+ void onClose(TriRpcStatus status, Map<String, Object> trailers,
Map<String, String> triExceptionCodeAttachments);
Review Comment:
Is it possible to have more than one exceptionCode? Why use maps
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/UnaryServerCallListener.java:
##########
@@ -34,6 +35,9 @@ public UnaryServerCallListener(RpcInvocation invocation,
Invoker<?> invoker,
@Override
public void onReturn(Object value) {
+ if (value instanceof Exception) {
Review Comment:
Seems unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
