PhoenixBackendon commented on issue #12334: URL: https://github.com/apache/dubbo/issues/12334#issuecomment-1554546614
> > I see what you mean. The current solution is configured as forced remote in the settings, which should be able to solve it, or we can provide a rule to adapt to the requirements based on this broadcasting mechanism, and I will finish it later. > > https://github.com/PhoenixBackendon/dubbo/blob/35da167f6a921f9c0c0799b807442f72d0fefaff/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/wrapper/ScopeClusterInvoker.java#L132 `logger.debug()` should consider use placeholder `{}` . I completely agree with your point. Although the Dubbo logger is configuration-based and not all underlying loggers support placeholder-style value assignment, Dubbo currently only supports logger.debug(String message) instead of logger.debug(String message, Object... params) for logging. I suggest adding a conversion layer in the logger to enable placeholder-style logging, which would better align with elegant logging practices. This improvement would not only enhance code readability and maintainability but also provide greater flexibility and extensibility in logging. I propose that we create an issue to discuss and implement this enhancement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
