baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424979498
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok :=
config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+
SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
Adding a default port to the current policy causes CI failures, need delete
default port or change default port?
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok :=
config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+
SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
default port cause ci fail ,link:
https://github.com/apache/dubbo-go/actions/runs/7191807715/job/19588269066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
