FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424999293
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok :=
config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+
SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port set by user or default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
