chickenlj commented on code in PR #13944:
URL: https://github.com/apache/dubbo/pull/13944#discussion_r1529883914
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java:
##########
@@ -150,7 +150,7 @@ public synchronized void register() throws RuntimeException
{
}
if (this.serviceInstance == null) {
ServiceInstance serviceInstance =
createServiceInstance(this.metadataInfo);
- if (!isValidInstance(serviceInstance)) {
+ if (!isValidInstance(serviceInstance, applicationModel)) {
Review Comment:
This might cause an invalid instance to be registered to the registry for
the first time and never get updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
