xieshouyu commented on code in PR #13944:
URL: https://github.com/apache/dubbo/pull/13944#discussion_r1531430423
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java:
##########
@@ -150,7 +150,7 @@ public synchronized void register() throws RuntimeException
{
}
if (this.serviceInstance == null) {
ServiceInstance serviceInstance =
createServiceInstance(this.metadataInfo);
- if (!isValidInstance(serviceInstance)) {
+ if (!isValidInstance(serviceInstance, applicationModel)) {
Review Comment:
ok, Change the new defaultServiceInstance to createServiceInstance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
