chickenlj commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536772943


##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
 
     <dependencyManagement>
         <dependencies>
+            <dependency>
+                <groupId>org.apache</groupId>
+                <artifactId>apache</artifactId>
+                <version>31</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>

Review Comment:
   I don't understand why we need to add this dependency when the following has 
already been set as the parent of the demo project:
   
   ```xml
   <parent>
       <groupId>org.apache</groupId>
       <artifactId>apache</artifactId>
       <version>31</version>
       <relativePath/>
   </parent>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to