walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536997259
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
1、The 'root pom.xml' and the '1-basic/pom.xml' does not set this parent.
Maybe in diffrent branch ?
2、The project structure of the current project is split. For example, 'root
pom.xml' sets '1-basic/pom.xml' as module, but '1-basic/pom.xml' does not set
'root pom.xml' as parent. Therefore, the component versions in
'1-basic/pom.xml' and subordinate pom.xml are not controlled by 'root pom.xml'.
And the parent of
'dubbo-samples-spring-boot-idl/dubbo-samples-spring-boot-idl-provider/pom.xml'
is set to 'dubbo-samples-spring-boot-idl/pom.xml', so dubbo
-samples-spring-boot-idl The component versions of this subproject are
controlled by 'dubbo-samples-spring-boot-idl/pom.xml'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
