BitoAgent commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1544735337
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -353,14 +353,14 @@
// refresh MethodConfigs
List<MethodConfig> methodConfigs = this.getMethods();
- if (methodConfigs != null && methodConfigs.size() > 0) {
+ if (methodConfigs != null && !methodConfigs.isEmpty()) {
Review Comment:
**Suggestion**: Using '!methodConfigs.isEmpty()' instead of
'methodConfigs.size() > 0' is more idiomatic and readable. Good job on this
change. <br> **Code Suggestion**:
```
The change is correctly applied as suggested.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
