BitoAgent commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1544735343
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -748,7 +748,7 @@
if (methodsJson != null) {
this.methods = new ArrayList<>();
methodsJson.forEach(
- (methodConfigJson) ->
methods.add(JsonUtils.toJavaObject(methodConfigJson, MethodConfig.class)));
+ methodConfigJson ->
methods.add(JsonUtils.toJavaObject(methodConfigJson, MethodConfig.class)));
Review Comment:
**Suggestion**: Removing unnecessary parentheses in lambda expressions can
simplify the code. Good job on this cleanup. <br> **Code Suggestion**:
```
The provided change is correctly applied as suggested.
```
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -252,7 +252,7 @@
}
if (CollectionUtils.isNotEmpty(this.registries)) {
this.registries.forEach(registryConfig -> {
- if (registryConfig.getScopeModel() != applicationModel) {
+ if (registryConfig != null && registryConfig.getScopeModel()
!= applicationModel) {
Review Comment:
**Security Issue**: Null check is added before accessing the
'registryConfig.getScopeModel()'. This prevents potential NullPointerExceptions
when registryConfig is null. <br> **Fix**: Ensure that registryConfig is not
null before accessing its methods or fields to avoid NullPointerException. <br>
**Code Suggestion**:
```
- if (registryConfig.getScopeModel() != applicationModel) {
+ if (registryConfig != null &&
registryConfig.getScopeModel() != applicationModel) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
