qingkaiyan commented on code in PR #14409:
URL: https://github.com/apache/dubbo/pull/14409#discussion_r1673425327


##########
dubbo-common/src/main/java/org/apache/dubbo/common/url/component/URLParam.java:
##########
@@ -483,7 +483,7 @@ public String getAnyMethodParameter(String key) {
      * @return A new URLParam
      */
     public URLParam addParameter(String key, String value) {
-        if (StringUtils.isEmpty(key) || StringUtils.isEmpty(value)) {
+        if (StringUtils.isEmpty(key)) {

Review Comment:
   And a consumer with a * version invoke a null version provider worked well 
at 2.7
   I use different version and condition-router to achieve gray and business 
group
   And like to make the dubbo:consumer version = *
   It's not work when I update to 3.2 or 3.3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to