AlbumenJ commented on code in PR #14409:
URL: https://github.com/apache/dubbo/pull/14409#discussion_r1679108241
##########
dubbo-common/src/main/java/org/apache/dubbo/common/url/component/URLParam.java:
##########
@@ -483,7 +483,7 @@ public String getAnyMethodParameter(String key) {
* @return A new URLParam
*/
public URLParam addParameter(String key, String value) {
- if (StringUtils.isEmpty(key) || StringUtils.isEmpty(value)) {
+ if (StringUtils.isEmpty(key)) {
Review Comment:
`URL` is a really really basic component for Dubbo, so I would prefer not to
change it enless we have the conclusion that we can only change it to fix a
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
