ThisaraWeerakoon commented on code in PR #826:
URL: https://github.com/apache/dubbo-go-samples/pull/826#discussion_r2041103407
##########
llm/config/config.go:
##########
@@ -94,6 +95,18 @@ func Load(envFile string) (*Config, error) {
return
}
config.NacosURL = nacosURL
+ maxContextStr := os.Getenv("MAX_CONTEXT_COUNT")
+ defaultMaxContextCount := 3 // Default to 3 for backward
compatibility
+ if maxContextStr == "" {
+ config.MaxContextCount = defaultMaxContextCount
+ return
Review Comment:
Thank for the suggestions. Added defaultMaxContextCount as a contant.
However, I believe the `return` statement in the `if maxContextStr == ""`
block is necessary. Without it, the function would proceed to parse an empty
string using `strconv.Atoi`, which would result in a runtime error (invalid
syntax).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
