Alanxtl commented on code in PR #826:
URL: https://github.com/apache/dubbo-go-samples/pull/826#discussion_r2041122381
##########
llm/config/config.go:
##########
@@ -94,6 +95,18 @@ func Load(envFile string) (*Config, error) {
return
}
config.NacosURL = nacosURL
+ maxContextStr := os.Getenv("MAX_CONTEXT_COUNT")
+ defaultMaxContextCount := 3 // Default to 3 for backward
compatibility
+ if maxContextStr == "" {
+ config.MaxContextCount = defaultMaxContextCount
+ return
Review Comment:
```suggestion
maxContextStr := os.Getenv("MAX_CONTEXT_COUNT")
if maxContextStr == "" {
config.MaxContextCount = defaultMaxContextCount
} else {
maxContext, err := strconv.Atoi(maxContextStr)
if err != nil {
configErr = fmt.Errorf("invalid
MAX_CONTEXT_COUNT value: %v", err)
return
}
config.MaxContextCount = maxContext
}
```
The logic should be like this, if you return in ```if maxContextStr == ""```
it would cause the rest of the cfg fields (if any) to be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
