EandrewJones commented on code in PR #407: URL: https://github.com/apache/flagon-useralejs/pull/407#discussion_r1479014066
########## src/UserALEWebExtension/optionsPage.html: ########## @@ -19,31 +19,30 @@ <html> <head> <title>User ALE Web Extension - Options</title> - <script src="globals.js"></script> <script src="options.js"></script> <meta charset="utf-8"> </head> <body> <h1>Options</h1> <form> <label>User ALE Server Host:</label> - <input id="host"/> + <input id="url"/> <br/> <label>User ALE Client Script:</label> <input id="clientScript"/> <br/> <label>User:</label> - <input id="toolUser"/> + <input id="user"/> <br/> <label>Tool Name:</label> - <input id="toolName"/> + <input id="tool"/> Review Comment: Same as previous comment. ########## build/UserALEWebExtension/optionsPage.html: ########## @@ -19,31 +19,30 @@ <html> <head> <title>User ALE Web Extension - Options</title> - <script src="globals.js"></script> <script src="options.js"></script> <meta charset="utf-8"> </head> <body> <h1>Options</h1> <form> <label>User ALE Server Host:</label> - <input id="host"/> + <input id="url"/> <br/> <label>User ALE Client Script:</label> <input id="clientScript"/> <br/> <label>User:</label> - <input id="toolUser"/> + <input id="user"/> <br/> <label>Tool Name:</label> - <input id="toolName"/> + <input id="tool"/> Review Comment: Is there a reason this differs from the javascript package naming conventions? ########## build/UserALEWebExtension/optionsPage.html: ########## @@ -19,31 +19,30 @@ <html> <head> <title>User ALE Web Extension - Options</title> - <script src="globals.js"></script> <script src="options.js"></script> <meta charset="utf-8"> </head> <body> <h1>Options</h1> <form> <label>User ALE Server Host:</label> - <input id="host"/> + <input id="url"/> <br/> <label>User ALE Client Script:</label> <input id="clientScript"/> <br/> <label>User:</label> - <input id="toolUser"/> + <input id="user"/> <br/> <label>Tool Name:</label> - <input id="toolName"/> + <input id="tool"/> <br/> <label>Tool Version:</label> - <input id="toolVersion"/> + <input id="version"/> Review Comment: Same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org