Jyyjy commented on PR #407: URL: https://github.com/apache/flagon-useralejs/pull/407#issuecomment-1928469197
> Very minor comments on the code itself. > > > > Only question: Do we have any tests for the plugin? If not, why not? If yes, please add some to, at minimum, verify the code fixes the bugs and ensure the refactor doesn't break existing behavior or introduce new bugs. > > > > The code changes appear to be a very nice simplification. But I am always hesitant to refactor without any way to validate. No plug-in tests exist. I think the plug-in has historically been an experimental tool only. That said it's already in my notes to write some plug-in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org For additional commands, e-mail: notifications-h...@flagon.apache.org
