EandrewJones commented on code in PR #411:
URL: https://github.com/apache/flagon-useralejs/pull/411#discussion_r1486752145
##########
src/getInitialSettings.js:
##########
@@ -52,6 +52,15 @@ export function getInitialSettings() {
settings.authHeader = get('data-auth') || null;
settings.custIndex = get('data-index') || null;
settings.headers = get('data-headers') || null;
+
+ if ((settings.toolName || "") === "") {
Review Comment:
same as above.
##########
src/UserALEWebExtension/background.js:
##########
@@ -41,6 +42,14 @@ const defaultConfig = {
var urlWhitelist;
function updateConfig(config) {
+ if ((config.toolName || "") === "") {
Review Comment:
in JS you can simply do:
`if (!config.toolName)`
both undefined and "" are "falsy" values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
