EandrewJones commented on code in PR #411:
URL: https://github.com/apache/flagon-useralejs/pull/411#discussion_r1486847853
##########
src/getInitialSettings.js:
##########
@@ -42,7 +42,7 @@ export function getInitialSettings() {
settings.transmitInterval = +get('data-interval') || 5000;
settings.logCountThreshold = +get('data-threshold') || 5;
settings.userId = get('data-user') || null;
- settings.version = get('data-version') || null;
+ settings.toolVersion = get('data-version') || null;
Review Comment:
this is where I was referencing changing the script tag to match the setting
name.
so it'd be:
`get('data-tool-version')`
This is a breaking change, because it changes the script-tag api. And since
toolVersion is required, the script would throw if users did not set this field.
We should add a default besides `null` to keep it from breaking (e.g. '1.0').
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
