rc10house commented on code in PR #47:
URL: https://github.com/apache/flagon-distill/pull/47#discussion_r1671029358
##########
distill/core/log.py:
##########
@@ -46,7 +47,8 @@ def __init__(self, data: Union[str, JsonDict],
schema=UserAleSchema):
raise TypeError("ERROR: " + str(type(data)) + " data should be
either a string or a JsonDict")
self.data = schema(**data)
- # TODO: need to create ID field here on object initialization
+ self.id = PKSUID("log", schema._timestamp(self.data))
Review Comment:
Bake the userId into the PKSUID as Evan mentioned in the call to make the
log truly globally unique. Ex: `log_userId_hash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
