EandrewJones commented on code in PR #47:
URL: https://github.com/apache/flagon-distill/pull/47#discussion_r1672747124
##########
distill/schemas/userale.py:
##########
@@ -80,3 +83,8 @@ def validate_ct(cls, ct: float):
def serialize_ct(self, ct: datetime):
return int(ct.timestamp() * 1000)
+ def _timestamp(self):
+ """
+ Returns timestamp as datetime object from userALE log's client_time
field
Review Comment:
Also wrong. Returns a POSIX time as float.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@flagon.apache.org
For additional commands, e-mail: notifications-h...@flagon.apache.org
