kpm1985 commented on a change in pull request #1004: FLUO-1000 OracleServer 
race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r162750855
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
 ##########
 @@ -410,15 +417,18 @@ public void takeLeadership(CuratorFramework 
curatorFramework) throws Exception {
       }
 
       synchronized (this) {
+        // FLUO-1000
+        isLeader = true;
+        while 
(!curatorFramework.getState().equals(CuratorFrameworkState.STARTED)) {
 
 Review comment:
   Tried that, it failed. @keith-turner Thank you for looking at this, I've put 
a lot of invisible work into it and am greatful for your review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to