kpm1985 commented on a change in pull request #1004: FLUO-1000 OracleServer
race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r162750867
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
##########
@@ -195,18 +195,25 @@ public OracleServer(Environment env) throws Exception {
private void allocateTimestamp() throws Exception {
Stat stat = new Stat();
- byte[] d =
curatorFramework.getData().storingStatIn(stat).forPath(maxTsPath);
+ // FLUO-1000
+ synchronized (this) {
Review comment:
Please correct me if I am wrong but I was under the impression that object
locks do not inherit from my reading of Doug Lea's Concurrent Programming.
https://stackoverflow.com/questions/9525882/if-a-synchronized-method-calls-another-non-synchronized-method-is-there-a-lock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
