cjmctague commented on a change in pull request #995: fixes #980
URL: https://github.com/apache/fluo/pull/995#discussion_r162832722
##########
File path: modules/core/pom.xml
##########
@@ -73,6 +73,10 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
Review comment:
I found that `<scope>provided</scope>` would exclude it from the shaded jar
so I went with `<optional>true</optional>`
Also the shaded plugin doesn't modify the original POM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
