cjmctague commented on a change in pull request #995: fixes #980
URL: https://github.com/apache/fluo/pull/995#discussion_r162832996
##########
File path: modules/core/pom.xml
##########
@@ -141,6 +132,34 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.thrift</pattern>
+ <shadedPattern>org.shaded.thrfit</shadedPattern>
+ </relocation>
+ </relocations>
+ <artifactSet>
+ <includes>
+ <include>org.apache.fluo.core.*</include>
+ <include>org.shaded.thrift:*</include>
+ <include>org.apache.thrift:*</include>
Review comment:
I changed them up. The `org.apache.fluo.core.*` include is needed so the
plugin doesn't pull from the entire project but rather just this module.
The `<include>org.shaded.thrift:*</include>` was needed to include the new
shaded artifact and the `<include>org.apache.thrift:*</include>` was needed for
the plugin to relocate thrift.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
