SlickNik commented on a change in pull request #270: Support Accumulo installs on Microsoft Azure URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r318777325
########## File path: ansible/roles/azure/vars/.gitignore ########## @@ -0,0 +1 @@ +main.yml Review comment: This is a good idea, in general. In these specific cases though, the generated files are specific to the ansible playbooks which need to reside in the specific playbook-related folder structure. There are some other examples of this in the muchos as well that we could consolidate. It would be good to re-visit this in another PR and see if we can move them out to a single folder (and perhaps pass them in as args to 'ansible-playbook' runs potentially using '--extra-variables' or something similar?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
