SlickNik commented on a change in pull request #270: Support Accumulo installs 
on Microsoft Azure
URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r318779340
 
 

 ##########
 File path: ansible/roles/common/tasks/hosts.yml
 ##########
 @@ -18,4 +18,4 @@
 - name: "ensure hostname is correct"
   hostname: name={{ inventory_hostname }}
 - name: "ensure /etc/hosts is correct"
-  template: src=roles/common/templates/etc_hosts dest=/etc/hosts owner=root 
group=root mode=0644
+  copy: src=/etc/etc_hosts dest=/etc/hosts owner=root group=root mode=0644
 
 Review comment:
   This copies the /etc/etc_hosts file on the proxy (which has already been 
expanded using the template in ansible/roles/proxy/tasks/main.yml) to 
/etc/hosts on the various nodes. Essentially this speeds things up doing the 
template expansion once on the proxy (followed by this file copy) as opposed to 
doing the same template expansion for every node. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to