sputnik13 commented on a change in pull request #288: Refactor config
URL: https://github.com/apache/fluo-muchos/pull/288#discussion_r332234133
##########
File path: lib/muchos/config/base.py
##########
@@ -244,13 +276,15 @@ def has_service(self, service):
return True
return False
+ # test method, might want to make private or just move to test module
Review comment:
yes it should be pretty straight forward, especially since python has no
notion of variable hiding or protection, test code can access and/or modify any
internal variables just fine. Making private in python land is adding
underscore prefix(es) and is more a convention than a rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
