sputnik13 commented on a change in pull request #288: Refactor config URL: https://github.com/apache/fluo-muchos/pull/288#discussion_r332236924
########## File path: lib/muchos/config/decorators.py ########## @@ -0,0 +1,98 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from collections.abc import Iterable +from functools import wraps + + +_host_vars = [] +_play_vars = [] +_extra_vars = [] +_ansible_vars = dict( + host=[], Review comment: yes I will add documentation. The middle term is the class name, so that we can filter out any cluster types that don't apply. Since the decorators are run when definitions (python files) are read, and config/__init__.py is importing all cluster types, all cluster type config definitions are read, and we needed to ensure we weren't trying to render ec2 variables when dealing with azure clusters, and vice versa. I will make this clear in documentation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
